search

353solutions / carrow

Go wrapper for Apache Arrow C++
https://arrow.apache.org/
BSD 3-Clause "New" or "Revised" License
15 stars 0 forks source link

Build artifacts with docker #49

Open tebeka opened 4 years ago

tebeka commented 4 years ago

Currently make artifact-linux-x86_64 will build the atrifact on the host machine. IMO we should build it via docker container (can do with a shared volume or copy from the build container).

@yonidavidson WDYT?

yonidavidson commented 4 years ago

Pros - good idea - I actually used both techniques. shared volume is easier (but you still have a host), copy from container is cleaner but you need to save the container id (you get it from the run command), can be annoying to write it when you develop in Java since build is long but in Go is the prefered way IMO. Cons - lets say we move our project to github actions for example so we can build in mac and windows, if we build in docker we won't be able to leverage the platforms for the different builds

tebeka commented 4 years ago

Cons - lets say we move our project to github actions for example so we can build in mac and windows, if we build in docker we won't be able to leverage the platforms for the different builds

Agree. However the compatibility problem is very linux specific