353solutions / carrow

Go wrapper for Apache Arrow C++
https://arrow.apache.org/
BSD 3-Clause "New" or "Revised" License
15 stars 0 forks source link

Start of CSV (WIP) #53

Closed tebeka closed 4 years ago

yonidavidson commented 4 years ago

@tebeka can we discuss the design?

tebeka commented 4 years ago

In general - I am not a great fan of inheritance.

It's not inheritance, we're implementing an interface.

I think that a simpler design would be to pass the csv arrow::io::InputStream pointer and to pass another reader class.

The idea is to provide at the Go level an io.Reader. This class implements a callback from C to Go to use this reader.