37Rb / nextcloud-hledger

Plain Text Accounting on Nextcloud
GNU Affero General Public License v3.0
13 stars 2 forks source link

Reasons for not autoloading #22

Open vascowhite opened 2 years ago

vascowhite commented 2 years ago

In line 5 of hledger.php you have a TODO comment wondering why autoloading doesn't work for your app.

I suspect that it is a combination of your app installing into /vendor rather than /apps/hledger/ and your name spacing not conforming with the Nextcloud conventions https://docs.nextcloud.com/server/latest/developer_manual/app_development/bootstrap.html.

I post this in a spirit of wanting to help, not as a criticism. I am interested in using your app, but as it stands I won't attempt to install it in case it borks my system in someway due to the unusual install location. Please feel free to correct me if I am mistaken about the install location.

Well done with the work you have done so far, it would be great to be able to install this directly from the Nextcloud app store.

vascowhite commented 2 years ago

On further reading, maybe I am mistaken about the install location. However, the namspacing still doesn't look quite right to me.