389ds / 389-ds-base

The enterprise-class Open Source LDAP server for Linux
https://www.port389.org/
Other
211 stars 93 forks source link

Fix slapi_td_plugin_lock_init prototype #1230

Closed 389-ds-bot closed 4 years ago

389-ds-bot commented 4 years ago

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/47899


FreeIPA compilation gives a GCC warning in a 389-ds header:

In file included from ipa_dns.c:54:0:
/usr/include/dirsrv/slapi-plugin.h:5585:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
 int slapi_td_plugin_lock_init();
 ^

Here is the fix

diff --git a/ldap/servers/slapd/slapi-plugin.h b/ldap/servers/slapd/slapi-plugin.h
index f1ecfe8..268e465 100644
--- a/ldap/servers/slapd/slapi-plugin.h
+++ b/ldap/servers/slapd/slapi-plugin.h
@@ -5582,7 +5582,7 @@ void slapi_td_get_val(int indexType, void **value);
 int slapi_td_dn_init(void);
 int slapi_td_set_dn(char *dn);
 void slapi_td_get_dn(char **dn);
-int slapi_td_plugin_lock_init();
+int slapi_td_plugin_lock_init(void);
 int slapi_td_set_plugin_locked(int *value);
 void slapi_td_get_plugin_locked(int **value);

--
389-ds-bot commented 4 years ago

Comment from pviktori at 2014-09-16 05:24:46

attachment 0001-Ticket-47899-Fix-slapi_td_plugin_lock_init-prototype.patch

389-ds-bot commented 4 years ago

Comment from nhosoi (@nhosoi) at 2014-10-08 02:12:00

Thanks to Petr Viktorin for providing the patch. I reviewed it.

389-ds-bot commented 4 years ago

Comment from nhosoi (@nhosoi) at 2014-10-08 02:14:53

Pushed to git repository on behalf of Petr.

master: cb17381..3104346 master -> master commit 3104346c574f17925c8113a30aa20116bf6a277c

389-ds-base-1.3.3: 1729443..e7a26dd 389-ds-base-1.3.3 -> 389-ds-base-1.3.3 commit e7a26ddaf5825a77a4c9ea59086316e815b2c175

389-ds-bot commented 4 years ago

Comment from nhosoi (@nhosoi) at 2017-02-11 23:02:49

Metadata Update from @nhosoi: