search

389ds / 389-ds-base

The enterprise-class Open Source LDAP server for Linux
https://www.port389.org/
Other
211 stars 93 forks source link

Uniqueness plugin: should allow to exclude some subtrees from its scope #1258

Closed 389-ds-bot closed 4 years ago

389-ds-bot commented 4 years ago

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/47927

As reported by https://fedorahosted.org/freeipa/ticket/4636, configuration using only uniqueness-subtrees introduces some constraints.

In the described use case, it would be more rapid to define uniqueness-subtrees-exclude from part of the DIT that should not be enforced

389-ds-bot commented 4 years ago

Comment from tbordaz (@tbordaz) at 2014-10-17 01:42:50

The IPA ticket ​https://fedorahosted.org/freeipa/ticket/4636 is related to 'Views'. 'Views' are targeted for Freeipa 4.1 which is going to be RHEL 7.1

389-ds-bot commented 4 years ago

Comment from mkosek at 2014-10-17 19:34:55

Alexander plans to work on this improvement together with tbordaz.

389-ds-bot commented 4 years ago

Comment from nhosoi (@nhosoi) at 2014-10-17 22:33:47

Ticket has been cloned to Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1154147

389-ds-bot commented 4 years ago

Comment from abbra at 2014-10-20 16:06:41

attachment dirsrv-abbra-0001-Support-excluding-subtrees-in-uniqueness-plugin.patch

389-ds-bot commented 4 years ago

Comment from abbra at 2014-10-20 16:07:07

Attached is the first cut to add exclude subtrees.

389-ds-bot commented 4 years ago

Comment from tbordaz (@tbordaz) at 2014-10-20 17:57:20

Hello Alexander,

The fix looks good. Just a remark in search_one_berval. I think that if one of the retrieved entry is part of an excluded subtree, it should rather continue to test the others entries than report LDAP_SUCCESS.

thanks thierry

389-ds-bot commented 4 years ago

Comment from abbra at 2014-10-20 18:04:22

It does continue to the other entries, it only skips this entry because of the excluded match. This is a nested loop and a break within the nested one only brings you to the outer loop, not out of it.

389-ds-bot commented 4 years ago

Comment from tbordaz (@tbordaz) at 2015-02-26 15:43:08

Alexander, you are right, no concern regarding search_one_berval. thanks

389-ds-bot commented 4 years ago

Comment from nhosoi (@nhosoi) at 2015-03-05 05:44:50

Hi Alexander,

I'm afraid uid.c had been modified and your patch fails to apply by "git am". Could it be possible to rebase with master on your checked out branch and recreate a patch? If you have the right to push the patch, please go ahead and do so. If not, we will do it. Thanks!! --noriko

389-ds-bot commented 4 years ago

Comment from tbordaz (@tbordaz) at 2015-04-30 23:49:12

attachment 0002-Ticket-47927-Uniqueness-plugin-should-allow-to-exclu.patch

389-ds-bot commented 4 years ago

Comment from rmeggins (@richm) at 2015-05-07 02:29:04

ack

389-ds-bot commented 4 years ago

Comment from tbordaz (@tbordaz) at 2015-05-07 18:53:42

Thanks Rich for the review

'''push to master'''

Updating cd8614a..cd9afbb Fast-forward dirsrvtests/tickets/ticket47823_test.py | 13 ++-- dirsrvtests/tickets/ticket47927_test.py | 300 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ ldap/servers/plugins/uiduniq/uid.c | 97 +++++++++++++++++++++----- 3 files changed, 389 insertions(+), 21 deletions(-) create mode 100644 dirsrvtests/tickets/ticket47927_test.py

git push origin master Counting objects: 20, done. Delta compression using up to 4 threads. Compressing objects: 100% (11/11), done. Writing objects: 100% (11/11), 4.01 KiB, done. Total 11 (delta 8), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git cd8614a..cd9afbb master -> master

commit cd9afbbeb1570adf663acb5b8f043a2012b839aa Author: Thierry Bordaz tbordaz@redhat.com Date: Tue Apr 28 19:35:34 2015 +0200

389-ds-bot commented 4 years ago

Comment from tbordaz (@tbordaz) at 2017-02-11 23:06:17

Metadata Update from @tbordaz: