389ds / 389-ds-base

The enterprise-class Open Source LDAP server for Linux
https://www.port389.org/
Other
213 stars 94 forks source link

In lib389 - MonitorLDBM class does not work properly when we turn off nsslapd-ndn-cache-enabled #2939

Open 389-ds-bot opened 4 years ago

389-ds-bot commented 4 years ago

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/49880


Issue Description

With the help of src/lib389/lib389/monitor.py I was trying to assert :: log.info("Check the backend monitor output for Normalized DN cache statistics while nsslapd-ndn-cache-enabled is on") topo.standalone.config.set('nsslapd-ndn-cache-enabled', 'on') monitor_backend = MonitorBackend(topo.standalone) assert monitor_backend.present('normalizeddncachehits')

so it should be able to check normalizeddncachehits is present in monitor_backend when nsslapd-ndn-cache-enabled is on, but it does not work and gives error :smoking: E TypeError: search_ext() argument 1 must be str, not None

Full logs - http://pastebin.test.redhat.com/626448

389-ds-bot commented 4 years ago

Comment from amsharma (@amsharma3) at 2018-08-02 16:16:37

Also there is a weird check for the version in src/lib389/lib389/monitor.py in init for MonitorLDBM class. so even if we have the right version, but we turn off nsslapd-ndn-cache-enabled, the code will fail

389-ds-bot commented 4 years ago

Comment from amsharma (@amsharma3) at 2018-08-02 16:16:40

Metadata Update from @amsharma3:

389-ds-bot commented 4 years ago

Comment from mreynolds (@mreynolds389) at 2018-08-09 17:56:09

Metadata Update from @mreynolds389:

389-ds-bot commented 4 years ago

Comment from firstyear (@Firstyear) at 2019-02-04 02:41:37

I think the issue is we allow disabling of ndn cache. We should remove this parameter instead.

389-ds-bot commented 4 years ago

Comment from mreynolds (@mreynolds389) at 2020-02-12 16:59:15

Metadata Update from @mreynolds389: