389ds / 389-ds-base

The enterprise-class Open Source LDAP server for Linux
https://www.port389.org/
Other
213 stars 94 forks source link

Separate test code from lib389 #3082

Open 389-ds-bot opened 4 years ago

389-ds-bot commented 4 years ago

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/50023


Issue Description

topologies module is used only in tests. But because it's part of lib389, it pulls in pytest and its dependencies. Additionally, lib389 contains tests that are installed, but not needed for lib389 to function:

$ find /usr/lib/python3.7/site-packages/lib389/tests/ -type f  | wc -l
207
389-ds-bot commented 4 years ago

Comment from vashirov (@vashirov) at 2018-11-12 17:57:57

Metadata Update from @vashirov:

389-ds-bot commented 4 years ago

Comment from mreynolds (@mreynolds389) at 2018-11-15 17:52:37

Metadata Update from @mreynolds389:

389-ds-bot commented 4 years ago

Comment from vashirov (@vashirov) at 2018-12-12 17:09:22

Metadata Update from @vashirov:

389-ds-bot commented 4 years ago

Comment from mreynolds (@mreynolds389) at 2020-02-12 16:45:47

Metadata Update from @mreynolds389:

progier389 commented 1 year ago

As said in issue #5924, IMHO while removing lib389 dependency over pytest we should also redesign the topology framework: We should have a single lib389 function that should be able to specify the current options plus any template parameters , and options to add entries or replace values in the dse.ldif before starting the instance the the topology code that should be moved in the test framework could rely on it