389ds / 389-ds-base

The enterprise-class Open Source LDAP server for Linux
https://www.port389.org/
Other
200 stars 84 forks source link

RootDNAccessControlPlugin.set_open_time() fails #3463

Open 389-ds-bot opened 3 years ago

389-ds-bot commented 3 years ago

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/50405


Issue Description

RootDNAccessControlPlugin has set_open_time() and set_close_time() methods, but they can't be used because these plugin attributes should be set together. If I try to use just set_open_time(), server returns err=53, in the errors log:

[24/May/2019:09:24:36.526222533 -0400] - ERR - rootdn-access-control-plugin - rootdn_load_config - There must be a open and a close time.  Ignoring time based settings.
[24/May/2019:09:24:36.529887291 -0400] - ERR - rootdn-access-control-plugin - rootdn_init - Unable to load plug-in configuration
[24/May/2019:09:24:36.532256982 -0400] - ERR - plugin_setup - Init function "rootdn_init" for "RootDN Access Control" plugin in library "librootdn-access-plugin" failed
[24/May/2019:09:24:36.535201439 -0400] - ERR - plugin_restart - Plugin (cn=RootDN Access Control,cn=plugins,cn=config) failed to restart after configuration change (Init function "rootdn_init" for "RootDN Access Control" plugin in library "librootdn-access-plugin" failed.).  Reverting to original plugin entry.
[24/May/2019:09:24:36.538228204 -0400] - ERR - dse_pre_modify_plugin - The configuration change for plugin (cn=RootDN Access Control,cn=plugins,cn=config) could not be applied.
389-ds-bot commented 3 years ago

Comment from mreynolds (@mreynolds389) at 2019-05-30 17:40:44

Impacts CLI tools as well

389-ds-bot commented 3 years ago

Comment from mreynolds (@mreynolds389) at 2019-05-30 17:40:44

Metadata Update from @mreynolds389:

389-ds-bot commented 3 years ago

Comment from spichugi (@droideck) at 2019-05-30 18:29:38

Impacts CLI tools as well

CLI uses direct set attribute approach. But I agree, we should add an additional check in the CLI/UI that both open and close times are specified if any.

389-ds-bot commented 3 years ago

Comment from mreynolds (@mreynolds389) at 2020-02-12 16:32:50

Metadata Update from @mreynolds389:

389-ds-bot commented 3 years ago

Comment from mreynolds (@mreynolds389) at 2020-02-26 16:23:13

Metadata Update from @mreynolds389: