389ds / 389-ds-base

The enterprise-class Open Source LDAP server for Linux
https://www.port389.org/
Other
211 stars 91 forks source link

PR - Issue 50954 - Port buildnum.pl to python #4010

Closed 389-ds-bot closed 4 years ago

389-ds-bot commented 4 years ago

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50957


Description:

Replace buildnum.pl with a python version so we can continue to remove perl dependencies.

relates: Resolves: #4007

389-ds-bot commented 4 years ago

Comment from firstyear (@Firstyear) at 2020-03-14 00:27:20

Shouldn't this be shell python?

389-ds-bot commented 4 years ago

Comment from firstyear (@Firstyear) at 2020-03-14 00:27:53

Beside that one comment (which probably necesitates a retest ^^;) you have my ack

389-ds-bot commented 4 years ago

Comment from mreynolds (@mreynolds389) at 2020-03-14 00:33:09

Shouldn't this be shell python?

Hmm, it does work as is, but it's definitely not right :-p Let me rework and test it....

389-ds-bot commented 4 years ago

Comment from mreynolds (@mreynolds389) at 2020-03-14 00:39:44

rebased onto 3deb6ad7d19774feb15c46f925059efe19462098

389-ds-bot commented 4 years ago

Comment from mreynolds (@mreynolds389) at 2020-03-14 00:40:35

Shouldn't this be shell python?

Fixed, and tests are good. Merging...

389-ds-bot commented 4 years ago

Comment from mreynolds (@mreynolds389) at 2020-03-14 00:41:10

Pull-Request has been merged by mreynolds389

389-ds-bot commented 4 years ago

Patch 50957.patch