search

389ds / 389-ds-base

The enterprise-class Open Source LDAP server for Linux
https://www.port389.org/
Other
211 stars 91 forks source link

Add GitHub actions #4577

Open vashirov opened 3 years ago

vashirov commented 3 years ago

Issue Description Using GitHub actions we should be able to run tests, static analysis, compile using gcc/clang, etc. on each PR or push to the repository.

Firstyear commented 3 years ago

Is something going weird here? Had a ton of notifications about this ....

vashirov commented 3 years ago

Sorry for the spam, I was updating my PR, didn't realize it generated so much noise :/

droideck commented 2 years ago

@vashirov I think you've made more progress than noted (in the checkboxes in the description). Or are we done completely?

vashirov commented 2 years ago

We're not done completely. I have patches for the remaining items, but they need some love. I was hesitant to add more checks because the existing ones generated a lot of warnings, but no one was looking at them. GitHub also has a limit of 50 visible annotations per run, so adding more checks would generate warnings that are simply not visible.

But now I see that we're down to 32 in the latest run: https://github.com/389ds/389-ds-base/actions/runs/1855623293 So I will revive my patches and submit PRs.

For lib389 tests we have https://github.com/389ds/389-ds-base/issues/5005 that needs to be fixed first, otherwise the check would always fail. I don't have capacity to work on this during Q1, so if someone else has free cycles to work on this, it would be great.