389ds / 389-ds-base

The enterprise-class Open Source LDAP server for Linux
https://www.port389.org/
Other
211 stars 92 forks source link

Minor cn=config nsslapd-haproxy-trusted-ip issues #6188

Closed droideck closed 5 months ago

droideck commented 5 months ago

Issue Description This ticket is for fixing minor issues with the nsslapd-haproxy-trusted-ip attribute. Issues:

We need to investigate the issues and decide how the behaviour should be defined (as our cn=config processing is different from usual LDAP modify operations)

droideck commented 5 months ago

Okay, for It is not present in cn=schema. - the PR is ready.

For the rest of the reported issues:

It is not present in cn=config by default.

We don't display the attribute if it doesn't have a value. So ldapsearch -xLLL -D "cn=Directory Manager" -w password -H ldap://localhost:389 -b cn=config nsslapd-haproxy-trusted-ip | grep haproxy will naturally fail as expected (nothing is found). But when the value is set, the ldapsearch will find the line.

Deleting a single value from the attribute doesn't work and requires server restart to get rid of the attribute.

Looks like it actually happens because of the old issue - https://github.com/389ds/389-ds-base/issues/2078 I think this issue should be fixed as part of the https://github.com/389ds/389-ds-base/issues/2078 ticket to avoid duplicates and cover all cases. It is a low priority, though.

droideck commented 5 months ago

b6c2d789b..245ffc01a 389-ds-base-3.0 -> 389-ds-base-3.0 fad9ff38b..6c7047ad7 389-ds-base-2.5 -> 389-ds-base-2.5 0e19d4e80..2884c2766 389-ds-base-2.4 -> 389-ds-base-2.4 3c7813341..01607109c 389-ds-base-1.4.3 -> 389-ds-base-1.4.3