search

389ds / 389-ds-base

The enterprise-class Open Source LDAP server for Linux
https://www.port389.org/
Other
213 stars 94 forks source link

Issue 6349 - RFE - extract keys once (#6363) (#6394) #6413

Open Firstyear opened 1 day ago

Firstyear commented 1 day ago

Bug Description: Keys/Certs are extracted to PEM repeatedly causing many warnings during outbound TLS authenticated replication

Fix Description: After more testing, if the connection is dropped and restarted, the certpath is retrieved but re-extraction does not occur. This still triggers the warning however. To resolve this, we only warn about the tpm namespace during library initialisation.

I really hope I got it right this time :(

fixes: https://github.com/389ds/389-ds-base/issues/6349

Author: William Brown william@blackhats.net.au

Review by: ???

Firstyear commented 1 day ago

I've been testing with replicas all afternoon killing and starting them to check this and it seems happier. So sorry this has been such a pain :(

vashirov commented 1 day ago

Minor nitpick: your commit and PR description point to a different issue. Judging by the title it should be #6394 instead of #6349.

progier389 commented 1 day ago

Minor nitpick: your commit and PR description point to a different issue. Judging by the title it should be https://github.com/389ds/389-ds-base/pull/6394 instead of https://github.com/389ds/389-ds-base/pull/6349.

Should not it point to an issue rather than a PR ?

vashirov commented 1 day ago

Minor nitpick: your commit and PR description point to a different issue. Judging by the title it should be #6394 instead of #6349.

Should not it point to an issue rather than a PR ?

Yes, it should point to an issue https://github.com/389ds/389-ds-base/issues/6340. BTW, please use full URL in the commit. It gets abbreviated by GitHub UI anyway, but makes life a bit easier during git log spelunking ;)

Firstyear commented 20 hours ago

Fixed up both issue. So sorry to have missed this, it was a very long day :(