Minimally viable addition package

390-2020-09-Fall / foofactors

Minimally viable R package based on the "R Packages" book Chapter 2: The whole game

https://r-pkgs.org/whole-game.html

Other

1 stars 0 forks source link

Minimally viable addition package #9

Open heschmidt opened 4 years ago

laurenslow commented 4 years ago

Hi @heschmidt I think rudeboybert's typo found its way into your code. In the toy_data.R file under the R folder, toy-data just needs to be changed to toy_data on line 12.

heschmidt commented 4 years ago

Thanks! I fixed that issue

rudeboybert commented 4 years ago

Hey @heschmidt, there is still some work that needs to be done here:

The package throws two warnings when running the check()
There is no added dataset beyond the toy_data example I provided. Also this dataset will need to be documented

rudeboybert commented 3 years ago

Hey @heschmidt, the unresolved issues I was referring to are the ones from my message above. In particular

Running the package check() does not pass. There are two warnings relating to the help file for the numadd() function
On top of adding a new function to the package, you need to add a new dataset. Instructions on how to do this are in Chapter 14 of the R packages book

heschmidt commented 3 years ago

I moved the data set to the right folder and I think it should be good now, but the check function isn't working so i'm not able to see those warnings

heschmidt commented 3 years ago

@rudeboybert I have now fixed the issues that were listed in the warnings

rudeboybert commented 3 years ago

Great! you're done. moodle updated