search

39aldo39 / DecSyncCC

Android app to sync contacts, calendars and tasks without a server using DecSync
GNU General Public License v3.0
232 stars 10 forks source link

Contact Name is required #82

Open alensiljak opened 2 years ago

alensiljak commented 2 years ago

The contacts without a name are not processed by DecSync.

When creating a contact for a company, which includes only the company name and the phone number, for example, these remain in the Android address book and are not synchronized.

The entries are considered invalid by DecSync because they do not have the display name (FN field, I think).

In my opinion, either

a) the company should be used for the FN field, if no other names exist, or b) FN should not be required to process a record

39aldo39 commented 2 years ago

I cannot reproduce this. When I create such contact it is correctly stored (with a FN), and when the collection is removed and added again it does correctly reappear. With which apps are you syncing, maybe the problem lies there?

alensiljak commented 2 years ago

One scenario that I can reproduce just using the phone is this:

The number of Android records will be smaller than the number of processed records by one. Delete the new record in Simple Contacts and the numbers will match again.

I may be able to get some contact records from the backups, in order to reproduce other issues. So far I've managed to clean everything up so this is to try to improve in general.

39aldo39 commented 2 years ago

If I create a new contact in Simple Contacts I don't even see a Company field. I see I have to enable it in the settings. After I do that it still works the same for me as the default contacts application.

alensiljak commented 2 years ago

That's weird. V6.16.3 from F-Droid:

Screenshot_20220106-230416_Contacts

39aldo39 commented 2 years ago

I do see it now (see the edit). What is your DecSync CC version? It could be the case that it didn't work in a previous version. I think it works from v2.2.0 and higher.

alensiljak commented 2 years ago

OK. Just for the record as something else could be the culprit, then

Screenshot_20220106-230635_Contacts

Screenshot_20220106-230655_Contacts

Screenshot_20220106-230715_DecSync_CC

The record, in the second screenshot, does not have the little head icon, which is a visual indicator for the field.

alensiljak commented 2 years ago

I do see it now (see the edit). What is your DecSync CC version? It could be the case that it didn't work in a previous version. I think it works from v2.2.0 and higher.

I've got v2.2.3 now. I think that's the current one on F-Droid.

alensiljak commented 2 years ago

BTW, thanks for making this! This is ingenious.