Make 3D-e-Chem branding optional

3D-e-Chem / tycho-knime-node-archetype

Maven archetype for Knime node extension

Apache License 2.0

5 stars 2 forks source link

Make 3D-e-Chem branding optional #16

Closed sverhoeven closed 6 years ago

sverhoeven commented 6 years ago

The archetype is 3D-e-Chem specific in the following ways:

3D-e-Chem logo in splash window during startup of KNIME, nl.esciencecenter.e3dchem.plugin in plugin/META-INF/MANIFEST.MF
Node in 3D-e-Chem category in node explorer, category-pathattribute in plugin\plugin.xml
Feature in 3D-e-Chem category in update site, category tags in p2/category.xml

When running generate you should have a option to skip the 3D-e-Chem specific things.

sverhoeven commented 6 years ago

Also the vendor name is hardcoded.

sverhoeven commented 6 years ago

org.knime.product dependency is included by the https://github.com/3D-e-Chem/knime-3d-e-chem/blob/master/plugin/META-INF/MANIFEST.MF, when not selecting a 3D-e-Chem branding this deps should be included.

Otherwise during testing you would get a org.knime.core.node.workflow.UnsupportedWorkflowVersionException: Unable to load workflow, it was created with a future version of KNIME (3.1.2.v201603311235). You are running 1.0.0.000000. error.