3DBAG / 3dbag-viewer

https://3dbag.nl
GNU General Public License v3.0
35 stars 10 forks source link

Compute true BoundingVolumes for 3dtiles #60

Closed jliempt closed 3 years ago

jliempt commented 3 years ago

The boundingVolumes (x,y) correspond with the extent of the centroids of the buildings which is wrong. And there's a problem with the z as can be seen in de debug mode of 3DTilesRendererJS.

jliempt commented 3 years ago

This is solved for now with pg2b3dm 1.3.3 (https://github.com/tudelft3d/pg2b3dm/tree/1.3.3). The bounding volumes now contain the full extent of the tiles rather than the extent of the centroids. The z-transform is removed since 3DTilesRendererJS doesn't use it when visualising the tiles, so a hack was used before in the viewer, which shifted the tiles with the z-transform but not the bounding volumes.

The size of the bounding volume of the root tile is now increased with the (original) z-transform, since removing the z-transform from the tileset would make it necessary to change the z-position of the root bounding volume, but this would give a problem in the viewer again, about which we will open an discussion/issue at 3DTilesRendererJS. But strictly seen, the tileset is already valid as it is now.