search

3DGenomes / TADbit

TADbit is a complete Python library to deal with all steps to analyze, model and explore 3C-based data. With TADbit the user can map FASTQ files to obtain raw interaction binned matrices (Hi-C like matrices), normalize and correct interaction matrices, identify and compare the so-called Topologically Associating Domains (TADs), build 3D models from the interaction matrices, and finally, extract structural properties from the models. TADbit is complemented by TADkit for visualizing 3D models
GNU General Public License v3.0
100 stars 61 forks source link

rmsdRMSD_wrapper return issue #188

Open julenmendieta opened 7 years ago

julenmendieta commented 7 years ago

when "one" is set to True, "what" should be taken into account to return; score, rmsd, drmsd or eqv. Now it only returns drmsd

https://github.com/3DGenomes/TADbit/blob/a258dcf455e6674303d81359f2d684b846fdb67c/src/3d-lib/eqv_rms_drms_py.cpp#L108

fransua commented 7 years ago

should take into account this use of the one=True flag: https://github.com/3DGenomes/TADbit/blob/324bb0357d4071bef054dadefcd535216ba4ba02/_pytadbit/modelling/structuralmodels.py#L481 The documentation of the parameter one should also be changed... Right now it is not the RMSD returned, but the dRMSD (as @julenmendieta says)