search

3DSGuy / Project_CTR

428 stars 66 forks source link

[Bug?] NCCH files do not require a .data section #142

Closed kynex7510 closed 1 year ago

kynex7510 commented 1 year ago

If we try to build 3ds_pdn without the workaround for generating the .data section, makerom fails with the following error:

[CODE ERROR] Failed to retrieve data sections from ELF
[NCCH ERROR] Failed to build ExeFs code
[NCCH ERROR] NCCH Build Process Failed
[RESULT] Failed to build NCCH (ret = -15)

This does not reflect HOS behaviour, which doesn't care about an empty .data section, and loads the sysmodule fine. (Tested on 11.17 with luma 12.0.1). The check should not be there and should be removed.

jakcron commented 1 year ago

I can probably fix this relatively easily. I'll ping you when I have some test builds :)

jakcron commented 1 year ago

Fixed as of MakeROM v0.18.4