3DStreet / 3dstreet-assets-source

🧊🌳🚗 3DStreet model source files
Other
2 stars 4 forks source link

On bike model, get red blinking bike light to be in a visible place #66

Closed kfarr closed 1 year ago

kfarr commented 1 year ago

goal: on dark maps to have blinking light of bike clearly visible in camera to reflect proper cyclist practices in-game

issue: current placement is not visible from elevated camera perspective

here is current picture from game showing red light not visible: image

here is a screenshot from a model viewer showing the camera angle required to see red light is much lower than the game camera angle image

instead, place red dot lower than its current position. it may need to float in between the two tubes supporting the rear wheel, or it can be attached to the left-hand tube only

cc @jlansey

JLansey commented 1 year ago

Also probably better even if it would stick further out the back, like - under the seat but in back so its not blocked by the seat. If you move it lower it might look physically too close to the wheel.

image
gnansai commented 1 year ago

Hi @kfarr @JLansey I have moved the red light to the seat back. Please check it and let me know your suggestions. image I have updated the glb file here https://github.com/gnansai/3dstreet-assets-dist/tree/main/sets/cyclist-animation/gltf-exports/draco

JLansey commented 1 year ago

The location is great, can we also make it wider/larger so it is more visible?

gnansai commented 1 year ago

Hi @JLansey I have made the light little bigger, Let me know your suggestions. image image image

kfarr commented 1 year ago

Hi @gnansai I see the updated position in the repo but I do not see this updated size one reflected. Can you update the dist files to reflect this?

gnansai commented 1 year ago

Hi @kfarr I have updated latest versions with bigger red light here. https://github.com/gnansai/3dstreet-assets-dist/tree/main/sets/cyclist-animation/gltf-exports/draco

kfarr commented 1 year ago

Hi @gnansai we got this working in the game and it is good enough, however there is an odd z-fighting thing going on with the light that we're not sure how to fix. You can see in this video how the light "shimmers"

https://github.com/3DStreet/3dstreet-assets-source/assets/470477/ca46fa2c-4f89-45d9-9b6b-b30a5f81d8aa

gnansai commented 1 year ago

Hi @kfarr I have used two geometries for red light blinking. The red bright light geometry moves forward and backward overlapping the red non bright geometry for light blinking effect. The geometries are located very close to each other and overlap during animation, hence the issue of z-fighting is occurring.

image

gnansai commented 1 year ago

Hi @kfarr I have tried to increase the distance between the light geometries to avoid z-fighting. Please test it and let me know. https://github.com/gnansai/3dstreet-assets-dist/tree/main/sets/cyclist-animation/gltf-exports/draco image

kfarr commented 1 year ago

looks good to me, i'll merge and we can close this

JLansey commented 1 year ago

oh that is actually quite a clever solution @gnansai ! Thank you - and thanks for fixing the z-fighting issue.