Save should not create a new scene ID just after having saved scene from another user

[kfarr]

To reproduce:

• sign in
• go to community scenes
• open a scene from another user, not your own
• make a change such as moving an object
• save > save the scene. This will create a new scene ID, as expected -- I am not the scene author so that is ok.
• Then make another change
• then click save > save scene.
• This will create a new scene ID -- NOT expected -- the one I just created should be saved, a new id should not be created

Related:

• assuming the logic above works correctly, it would still be helpful to be more explicit to an end-user when they are viewing a scene that will be "saved as" because it belongs to another user. This is now in a separate ticket: https://github.com/3DStreet/3dstreet-editor/issues/308

[kfarr]

I think the cause is:

• When the save button is pressed, first the save function looks for the current ID
• If an ID is provided in a-scene entity metadata component sceneId property, then use that value and do not check elsewhere
• However currently Save As... behavior does not appear to set metadata component sceneId after saving
• Therefore when attempting to Save, it will use the old ID and assume that the current user is not the author, therefore triggering a Save As... motion

To fix, perhaps after this line: https://github.com/3DStreet/3dstreet-editor/blob/master/src/components/scenegraph/Toolbar.js#L160

Add: AFRAME.scenes[0].setAttribute('metadata', 'sceneId: ' + currentSceneId);

Therefore setting scene entity metadata component sceneId property to currentSceneId where current user = author therefore performing Save operation correctly on future saves

[kfarr]

fixed on https://github.com/3DStreet/3dstreet-editor/pull/293, awaiting deployment