3DStreet / 3dstreet-editor

3DStreet Editor Repo
https://3dstreet.app
Other
19 stars 3 forks source link

fix: scenes fetching and tabs styles #378

Closed rostyslavvnahornyi closed 8 months ago

netlify[bot] commented 9 months ago

Deploy Preview for 3dstreet-editor-builds ready!

Name Link
Latest commit 51dc77f1cd7ac2d8375ec6387fe8451b54645b38
Latest deploy log https://app.netlify.com/sites/3dstreet-editor-builds/deploys/65b05d722a53c3000867bdae
Deploy Preview https://deploy-preview-378--3dstreet-editor-builds.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kfarr commented 9 months ago

@rostyslavvnahornyi

here is some feedback:

production - desired: image

this PR - needs fixing: image

production - desired: image

this PR - needs fixing: image

rostyslavnahornyi commented 9 months ago

@kfarr this task was done to #371 and #375 issues and also style changes for tab i did linking to figma. The selected tab in figma is darker that we currently have in prod. I think maybe to ask designer to revise these styles?

kfarr commented 9 months ago

@rostyslavnahornyi thanks for clarifying the relevant tickets to test this against.

Please use the current style from production for "active enabled tab on tabs container" and ignore the style guide in this case.

kfarr commented 8 months ago

thanks @rostyslavnahornyi !

I validated the following: