Closed Algorush closed 6 months ago
Name | Link |
---|---|
Latest commit | 150367d61d4d363ed474ec3a1e5f516d04f00544 |
Latest deploy log | https://app.netlify.com/sites/3dstreet-editor-builds/deploys/65a4895dee76ec0008b83697 |
Deploy Preview | https://deploy-preview-383--3dstreet-editor-builds.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Thanks @Algorush. Which tram? If it is this model then you can ignore as we will be replacing:
<a-asset-item id="trolleymodel" src="${assetUrl}objects/godarvilletram.gltf"></a-asset-item>
@Algorush Ok thanks well in that case yes we should support correct bounding box for that model.
I just tested this and while I wasn't able to test animation, things work as expected (nothing is broken) for bounding box behavior so I'll merge
@Algorush you may want my other change as well https://github.com/aframevr/aframe-inspector/pull/686/commits/ea6fb76500f90ecdfcc94d648ddfca17c664735e
@Algorush you may want my other change as well aframevr/aframe-inspector@ea6fb76
@vincentfretin Thank you very much for mention about this
Vincent Fretin from Aframe advise to remove the old function
Box3.prototype.expandByObject
to correctly defineboundingBox
: https://github.com/aframevr/aframe-inspector/pull/686 I did this in the 3DStreet-editor repository in this PR and now theboundingBox
is defined correctly for pedestrians and for almost all other objects... except the tram. I don't know why yet. Itβs interesting that in a clean scene with two objects - a tram and a pedestrian, the boundingBox is determined correctly for both