search

3DStreet / 3dstreet-editor

3DStreet Editor Repo
https://3dstreet.app
Other
18 stars 3 forks source link

pin 3dstreet core dependency to a specific version #388

Closed kfarr closed 5 months ago

kfarr commented 5 months ago

right now 3dstreet-editor imports the latest master build of 3dstreet core https://github.com/3DStreet/3dstreet-editor/blob/master/index.html#L8

therefore, independent of an editor release, there may be unexpected behavior on the editor due to 3dstreet core changes.

instead, we should lock the version of 3dstreet core to a specific version in 3dstreet-editor and only upgrade explicitly as part of the editor update process.

kfarr commented 5 months ago

for example, to pin the current version of 3dstreet instead of using master use this CDN link instead of github.3dstreet.org[path]: https://cdn.jsdelivr.net/npm/3dstreet@0.4.5/dist/aframe-street-component.min.js

kfarr commented 5 months ago

https://github.com/3DStreet/3dstreet-editor/pull/395