search

3DStreet / 3dstreet-editor

3DStreet Editor Repo
https://3dstreet.app
Other
18 stars 3 forks source link

fix camera tiles #410

Closed Algorush closed 4 months ago

netlify[bot] commented 4 months ago

Deploy Preview for 3dstreet-editor-builds ready!

Name Link
Latest commit d4fe1f38a3c12eb317bfe37fb401f8fe652c1d1c
Latest deploy log https://app.netlify.com/sites/3dstreet-editor-builds/deploys/660708c663a8cc00080e23bf
Deploy Preview https://deploy-preview-410--3dstreet-editor-builds.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kfarr commented 4 months ago

@Algorush issues remaining:

Algorush commented 4 months ago
  • 3d tiles do not update with inspector camera (in editor mode)

camera in Editor mode should work after applying also this PR from the Editor repo: https://github.com/3DStreet/3dstreet-editor/pull/410

kfarr commented 4 months ago

@Algorush yes I am testing on this PR #410. Here is a video of the current behavior. The component appears to not be paused (good!) but the tiles do not update based on the change of editor camera pose:

https://github.com/3DStreet/3dstreet-editor/assets/470477/129d13bd-5f2c-45b6-87c5-125f34b63bdd

kfarr commented 4 months ago

Also let's ignore the saving issue, it's a blessing in disguise that saving does not work

Algorush commented 4 months ago

Sorry, I linked in this PR instead of PR in aframe-loader-3dtiles: https://github.com/3DStreet/aframe-loader-3dtiles-component/pull/3 Camera should work with new dist of aframe 3dtiles component from this PR, have you tried with it?

kfarr commented 4 months ago

Ok this all works as expected now, thanks. I did have to copy this to the local repo for now. Later we could just publish this to npm and include as a dependency? I will remove from index.html and test adding via console and maybe even database

Algorush commented 4 months ago

I haven't added orthographic camera support yet. Almost finished it, I wanted to ask you to review it. And also later I will add a limitation of the tiles loading area. I will do it in 3dstreet/aframe-loader-3dtiles-component

Later we could just publish this to npm and include as a dependency?

I don't know if we need to add camera support in the nytimes/aframe-loader-3dtiles-component yet, because it depends on this PR 410. But updating camera tiles won't work in the aframe-inspector. Later I intend to make this work for aframe-inpector as well