feature/issue-408/entity-panel

[netlify[bot]]

✅ Deploy Preview for 3dstreet-editor-builds ready!

Name	Link
🔨 Latest commit	b2bba3608446e0299f0a5ad92112384a57b16286
🔍 Latest deploy log	https://app.netlify.com/sites/3dstreet-editor-builds/deploys/662f0a0833f65a0008e3e8dd
😎 Deploy Preview	https://deploy-preview-412--3dstreet-editor-builds.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[kfarr]

• addlayerbutton needs focus state (implemented correctly on addlayerpanel closeButton)
• How to populate menu - alex to work on that

[Algorush]

I added new parameter mixinGroups to options array. For specifying one or few mixin group names to show if option is selected:

  const options = [
    {
      value: 'Layers: Streets & Intersections',
      label: 'Layers: Streets & Intersections',
      onClick: () => console.log('Layers: Streets & Intersections')
    },
    {
      value: 'Models: Personal Vehicles',
      label: 'Models: Personal Vehicles',
      mixinGroups: ['vehicles', 'vehicles-rigged']
    },
    {
      value: 'Models: Transit Vehicles',
      label: 'Models: Transit Vehicles',
      mixinGroups: ['vehicles-transit']
    },

I sugest to store cardsData with objects data (mixin id, img, name, description) in separate json file. And options object with mixin group and Layers data in separate json file too for convenient. Where is better to store these files? One question about options array. Now there are many more categories of mixins than group names in options. I have done it now so that all mixins are displayed, without dividing them into subgroups in selectedOption. I see few variants to do here:

• display mixins by groups in the panel for convenience. Based on data from the mixinGroups parameter. Then we need to add styles to divide the list of objects to be added into groups.
• Or divide Options in mixin subgroups and display a option list with mixin subgroups.
• use sumething like hashtags for selecting mixin subgroups

[Algorush]

I added the ability to load layers by clicking on cards. And also svg-extruder element. All this is for testing. For now, all this is in one place - 'Layers: Streets & Intersections', it could be distributed among other groups later. All this works, but for example, when deleting a mapbox element from the scene, an error occurs in 3dstreet-editor, and also when deleting a new street, for some reason dummy elements are added to the structure of the existing street, after opening/closing the editor everything is fine. I will create isseus in Editor for it

[kfarr]

remaining before this can be merged:

• [ ] - test with saving
• [ ] - review logic for where to place these new objects -- as children or elsewhere?
• [ ] - review options for where to store json catalog of objects and how to generate catalog
• [ ] - fix scrolling behavior and other style issues (menu)

[Algorush]

Now adding and previewing objects correspond to the elevation level of the segment for which they are added. And also in this PR, I made that objects are always added as direct descendants of the parent segment of the currently selected entity in the scene. In another branch, objects are always added to a special entity with class .custom-group

[kfarr]

Checklist to complete v1:

• [ ] Choose which branch we are using for this -- there are 2?
• [ ] Errors while hovering for some objects - triage first
• [ ] Panel should be hidden behind a isBeta claim flag
• [ ] Review -- are these the layers that we need? Any missing? Any shouldn't be there?

LATER:

• [ ] LATER addlayerbutton needs focus state (implemented correctly on addlayerpanel closeButton)
• [ ] LATER Long-term should use a catalog.json format that is shared between core and editor. (Maybe even bring core into editor)
• [ ] LATER Long-term issue -- Hover preview – Is it always creating new entities or is it changing the value of 1 entity? Is it properly disposing of the gltf preview?
• [ ] LATER -- how to create input mechanism for user when placing an entity that has required properties (such as a src url when placing an image)

[kfarr]

see #421