Closed Algorush closed 2 months ago
Name | Link |
---|---|
Latest commit | b836e0872072fb0718d3b0c6f9a14c5651c8170f |
Latest deploy log | https://app.netlify.com/sites/3dstreet-editor-builds/deploys/662dbc370ba6940008f73edb |
Deploy Preview | https://deploy-preview-421--3dstreet-editor-builds.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Checklist to complete v1: Checklist
LATER:
Review -- are these the layers that we need? Any missing? Any shouldn't be there?
Still need to add layers (from Doc):
LATER Long-term issue -- Hover preview – Is it always creating new entities or is it changing the value of 1 entity? Is it properly disposing of the gltf preview?
Just for information - there is a special entity for the preview, which is created when the panel is opened and when user hover over the cards, its properties change (mixin, position)
Maybe we should add Segment Layer aslo? It could be just empty sidewalk/road/bike segment. But it's better to first create a segment component with approximate parameters: type (type from Streetmix) - road, sidewalk, bike path, ground, etc; elevation level -2, -1, 0, 1, 2; content (variantString from Streetmix) - for each type user can select variant from the list of variants, in accordance with the structure from segments-variants.js. Or we can in 3DStreet allow user to add any options that roughly correspond to the type of segment.
Regarding the preview method - did we settle on the current method of previewing an element - appearing in the middle of a segment? So I can remove the old code related to the preview of the element 5 meters in front of the camera?
@Algorush yes previewing on currently selected segment is good to start
issues to fix:
close by #428
Need to merge this PR in 3DStreet first to respect elevation level of new adding objects. This branch was created to test the approach when adding objects from the New Entity panel. Described here: https://github.com/3DStreet/3dstreet-editor/issues/408#issuecomment-2080332617