Open kfarr opened 9 months ago
should there be an option for animation? should this option only be available before loading the scene? or can it be toggled while the scene is active?
Global animation can be toggle in the street
component. I suggested in this issue how this switch can be made to work correctly. https://github.com/3DStreet/3dstreet/issues
Or I think it could be possible to toggle animation when scene is active without reload the scene. I'll see today
there are only 8 animated characters although there are 16 total characters
But I see only 8 animated characters here: https://github.com/3DStreet/3dstreet-assets-dist/tree/main/sets/human-characters-animation-seperated/gltf-exports/draco Or are they somewhere else? @kfarr , @gnansai
@Algorush excellenté please feel free to continue to explore and share
Separately there is another ticket to track progress of adding 8 more animated characters https://github.com/3DStreet/3dstreet-assets-source/issues/77
Here is PR for this ticket. Now added commit with live toggle globalAnimation https://github.com/3DStreet/3dstreet/pull/435
For the rest of the tasks I’m still doing debugging and testing
Separately there is another ticket to track progress of adding 8 more animated characters 3DStreet/3dstreet-assets-source#77
There is one suggestion about the characters and switching global animation. Now there is a separate glb's with animated character models and a separate glb's with static ones.
So I'll use 8 for now for the whole scene until another 8 are ready?
@Algorush yes, you're right, this is the best strategy. We should remove the static ones completely from the assets repo and the assets.js file.
However, initially I hesitate as I'd like to wait until all 16 characters are available, but then I think we might as well get started and @gnansai already has this next on his queue, so maybe keep working toward this and I'll wait to merge until the other 8 characters are ready?
As a user creating and modifying an animated 3DStreet scene from a Streetmix source, I expect to be able to click on objects in the scene and reposition them using the editor.
However, when animation is turned on the animated characters and vehicles do not behave as expected:
animation can be turned on with this line in index.html:
<a-entity id="default-street" street="globalAnimated: true;" streetmix-loader set-loader-from-hash></a-entity>
definition of done:
A few thoughts:
Proposed solution: