3DStreet / 3dstreet

🚲🚢🚌 Web-based 3D visualization of streets using A-Frame
https://3dstreet.app
Other
249 stars 30 forks source link

In geomodal, pressing the letter h in a place search it will close the modal #562

Closed kfarr closed 3 weeks ago

kfarr commented 3 weeks ago

This is caused by the default help keyboard shortcut h β†’ the same issue happened once before with a title rename feature, the workaround was to use isExtraCloseEnabled see: https://github.com/3DStreet/3dstreet-editor/pull/312/commits/f61e12060a152d68c7b871fca0a9d3d54c4df258#diff-3ca8a64d250a8f7449f132f6fac892d85418d0d3a642f95ca46fcbd69b6ab65c

Algorush commented 3 weeks ago

I did not quite understand. Why we need this code: extraCloseKeyCode={72}

Is this necessary so that when user press h, all windows will close and the help window will open?

kfarr commented 3 weeks ago

I did not quite understand. Why we need this code: extraCloseKeyCode={72}

Is this necessary so that when user press h, all windows will close and the help window will open?

it does nothing of value, should only be on the help modal, we should remove it and is resolves this issue

Algorush commented 3 weeks ago

This is now fixed after street-geo-editor merged