search

3DStreet / 3dstreet

🚲🚶🚌 Web-based 3D visualization of streets using A-Frame
https://3dstreet.app
Other
249 stars 30 forks source link

update aframe-loader-3dtiles-component: fix load errors #663

Closed Algorush closed 1 week ago

Algorush commented 1 week ago

Added check for this.viewportSize to the Tick function in aframe-loader-3dtiles-component.js to prevent error with undefined value described in this issue: https://github.com/3DStreet/3dstreet/issues/633 Also same issue: https://github.com/3DStreet/3dstreet/issues/661

vincentfretin commented 1 week ago

Is this https://github.com/3DStreet/aframe-loader-3dtiles-component/pull/9 ? This PR should really be on the board in the review column. Does the other PRs in https://github.com/3DStreet/aframe-loader-3dtiles-component/pulls also in the build? If yes those should be merged there.

Algorush commented 1 week ago

This PR should really be on the board in the review column.

yes, you right. Otherwise it gets confusing. I will remove PRs in 3DStreet

Algorush commented 1 week ago

Closed, because already have this PR: https://github.com/3DStreet/aframe-loader-3dtiles-component/pull/9

vincentfretin commented 1 week ago

Yeah but you need to copy the file in 3dstreet repository, so you still need this PR.

kfarr commented 1 week ago

Do we need both the minified and unminified versions here? nevermind, I removed the unminified file and files that used them

kfarr commented 1 week ago

@Algorush I will wait to merge this until you can confirm that the https://github.com/3DStreet/aframe-loader-3dtiles-component/ repo is actually up-to-date with what is intended to be in the 3dstreet repo

Algorush commented 1 week ago

Updated lib to the last version in last commit