3DStreet / 3dstreet

🚲🚢🚌 Web-based 3D visualization of streets using A-Frame
https://3dstreet.app
Other
266 stars 33 forks source link

Right panel not properly updated on new/load scene #819

Open vincentfretin opened 2 months ago

vincentfretin commented 2 months ago

Steps:

Issue: The right panel still show old data for street-environment component.

Solution: The right panel needs to refresh on newScene event.

vincentfretin commented 2 months ago

I tried to forceUpdate on newScene event in Sidebar, but that didn't work. I think the panel is still showing the removed environment entity, but changing the environment preset is still working, weird. I reproduce the issue with creating an entity, like putting a bus and showing the right panel, then load another scene, the right panel will still show the bus. I think more generally the issue here is that the right panel should close when an entity is unselected (or removed), we have the same issue with aframe-inspector, when you press Esc, the entity unselect in the viewport but is still selected in the scene graph and showing properties in the right panel.

vincentfretin commented 2 months ago

Related to this, the blue select box stays instead of disappearing when you load an other scene.