3DStreet / 3dstreet

🚲🚶🚌 Web-based 3D visualization of streets using A-Frame

https://3dstreet.app

Other

263 stars 33 forks source link

error to undo material texture src change #840

Open kfarr opened 2 months ago

kfarr commented 2 months ago

[object HTMLImageEleme...] instead of #actual-id after undo of texture change

https://github.com/user-attachments/assets/49db072d-0c72-43bd-b2a8-b65709dde6da

vincentfretin commented 2 months ago

Probably related to the entity serialization for asset properties. We did a fix related to that in aframe master https://github.com/aframevr/aframe/pull/5544 Let's see if we can make a workaround just to fix it without updating to aframe master.

vincentfretin commented 2 months ago

If in index.html you use an aframe master build (three r167) <script src="https://cdn.jsdelivr.net/gh/aframevr/aframe@4142ec90a76916d252e375ceb1595971ee264966/dist/aframe-master.min.js"></script> the issue is fixed. Really we should just update aframe, not worth the time to try to fix that in an old version.

vincentfretin commented 2 months ago

842

vincentfretin commented 2 months ago

We can do a custom 1.5.0 build with just the change from https://github.com/aframevr/aframe/pull/5544 that should be safer. I looked at the code, that's not possible to monkey patch propertyTypes, this object is not exposed.

vincentfretin commented 1 month ago

Reoponed because we reverted the aframe update in #850 and pending a fix for #851 before updating it again.