3Dickulus / FragM

Derived from https://github.com/Syntopia/Fragmentarium/
GNU General Public License v3.0
349 stars 30 forks source link

no image feedback in big-tile animation rendering #114

Closed claudeha closed 4 years ago

claudeha commented 4 years ago

Describe the bug When rendering an animation to disk and the image size is the same size as the display window, the image is displayed (which is nice to check that all is going ok). When the animation tile size is larger than the window size (I think, not sure of exact cause), the window doesn't update and it's necessary to check the image files on disk to see if all is going ok.

To Reproduce

  1. Load a cheap-to-render frag
  2. Drag widgets to make display window 960x540 pixels
  3. Render animation with 1 tile at 1920x1080, 1 subframe
  4. See error: window is not updated during rendering
  5. Render animation with 1 tile at 960x540 pixels, 1 subframe
  6. See okness: window is updated

Expected behavior Window updates with the image of the current frame.

Desktop (please complete the following information):

3Dickulus commented 4 years ago

if tile size is larger than window render area it does not update the screen, scaling issues or something, don't recall exactly but it is not a bug, it is intended behaviour but can be changed

also, updates after tile is rendered and if there is only one tile you might not see the update before rendering the next frame starts

3Dickulus commented 4 years ago

gl4dev branch doesn't update at all... yet.

3Dickulus commented 4 years ago

fixed in gl4dev branch in commit 0f852d4

tile size independent, look at MainWindow::renderTiled() for cheap/dirty (really simple) way to render image tiles over GL area ;) had to cheat a bit but it's simple and nets the same effect so gl4dev now updates as tiles are rendered.

3Dickulus commented 4 years ago

oops, updates on first anim frame but not after that, fixed the first bit but neglected to test further... partial fix so on the todo list.... coming soon...

3Dickulus commented 4 years ago

ok fixed in v2.5 rev 2