search

3Dpass / threedpass

3DPass mobile light wallet for Android and iOS. 3D object recognition and wallet functions.
https://3dpass.org/mobile-wallet
GNU General Public License v3.0
11 stars 5 forks source link

FEATURE: German translation #56

Closed Olli92 closed 7 months ago

L3odr0id commented 7 months ago

LGTM

L3odr0id commented 7 months ago

Oh. @Olli92, there are some interesting things about this PR.

  1. SetAccountFromRawSeed actually was already declared. It does the same thing as the new _setRawseed https://github.com/3Dpass/threedpass/blob/e4b9c1e1cbab474d886fbf54aaa6f53ca4fcea1c/lib/features/accounts/bloc/account_store_bloc/account_store_bloc.dart#L104

  2. To make rawseed actually usable you should add 0x to it :) https://github.com/3Dpass/threedpass/blob/b5391cf53c0ee50d84ad718951a9cdbdc646a0dd/lib/features/accounts/domain/rawseed_text.dart#L8

  3. Please don't make callbacks as arguments to widgets. There are already some similar callbacks in the app, I'm ashamed of them, but we shouldn't add more. https://github.com/3Dpass/threedpass/blob/9063da030bd32f2a363b3d814d06728d7e049c87/lib/features/accounts/presentation/widgets/import_mnemonic_form/address_icon_preview.dart#L10

I fixed all these problems in https://github.com/3Dpass/threedpass/commit/b5391cf53c0ee50d84ad718951a9cdbdc646a0dd . These details are important. Thank you for your contribution

Olli92 commented 7 months ago

Thanks, i will keep this things in mind!