Closed yc1976Python closed 7 months ago
Great work Yong!
Thanks Vitas. Just to confirm if I need to delete the branch or it can be done from your end? I downloaded the main branch and everything is working fine. Will start working on the spatial average part soon.
On Mon, 26 Feb 2024 at 13:56, Vitas Anderson @.***> wrote:
@.**** approved this pull request.
— Reply to this email directly, view it on GitHub https://github.com/3EMEgos/planeRF/pull/3#pullrequestreview-1899882546, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6XXMOFOAQFDFMGI7HYQSZDYVP2WXAVCNFSM6AAAAABDZGX2ISVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOJZHA4DENJUGY . You are receiving this because you authored the thread.Message ID: @.***>
Hi Yong,
You should delete your branch both locally and remotely. Each new change should be done on a separate branch created from the main branch (at least for now).
Best, Ante
pon, 26. velj 2024. u 06:23 Yong @.***> napisao je:
Thanks Vitas. Just to confirm if I need to delete the branch or it can be done from your end? I downloaded the main branch and everything is working fine. Will start working on the spatial average part soon.
On Mon, 26 Feb 2024 at 13:56, Vitas Anderson @.***> wrote:
@.**** approved this pull request.
— Reply to this email directly, view it on GitHub https://github.com/3EMEgos/planeRF/pull/3#pullrequestreview-1899882546,
. You are receiving this because you authored the thread.Message ID: @.***>
— Reply to this email directly, view it on GitHub https://github.com/3EMEgos/planeRF/pull/3#issuecomment-1963341390, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHSPGE5NQ52SB3QK66X3X2DYVQL5RAVCNFSM6AAAAABDZGX2ISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRTGM2DCMZZGA . You are receiving this because you were assigned.Message ID: @.***>
Hi Yong, You should delete your branch both locally and remotely. Each new change should be done on a separate branch created from the main branch (at least for now). Best, Ante pon, 26. velj 2024. u 06:23 Yong @.> napisao je: … Thanks Vitas. Just to confirm if I need to delete the branch or it can be done from your end? I downloaded the main branch and everything is working fine. Will start working on the spatial average part soon. On Mon, 26 Feb 2024 at 13:56, Vitas Anderson @.> wrote: > @.** approved this pull request. > > — > Reply to this email directly, view it on GitHub > <#3 (review)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/A6XXMOFOAQFDFMGI7HYQSZDYVP2WXAVCNFSM6AAAAABDZGX2ISVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOJZHA4DENJUGY> > . > You are receiving this because you authored the thread.Message ID: > **@.> > — Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHSPGE5NQ52SB3QK66X3X2DYVQL5RAVCNFSM6AAAAABDZGX2ISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRTGM2DCMZZGA . You are receiving this because you were assigned.Message ID: @.>
@akapet00, thanks. Yes, I just deleted the branch after it is merged to main. The code works well and I guess we can continue. Since we can edit the code even after installing the project package, I plan to make some major update locally to add the spatial averaged code for the ground reflection part. Update you both soon.
Below are the major changes for my latest commit. Please kindly review.