search

3F / vsSolutionBuildEvent

🎛 Event-Catcher with variety of advanced Actions to service projects, libraries, build processes, runtime environment of the Visual Studio, MSBuild Tools, and …
Other
79 stars 22 forks source link

Visual Studio 2019 supprt #44

Closed elangelo closed 5 years ago

elangelo commented 5 years ago

Any chance we might get this?

3F commented 5 years ago

Sure. This is still my active project (today, this is still actively integrated with our other projects). Therefore, I have plans for VS2019 too.

Just no time for fast support. Anybody can also help to add some (#39) support. I'll definitely review any PR.

Thanks for using and follow the news.

elangelo commented 5 years ago

I've been trying to get this to work on 2019 but i keep getting: image

If i remember correctly on 2017 you got a yes/no button to still install it. Somehow that no longer works on 2019. I'll keep trying... If you have any hints in what directions i should be looking that would be greatly appreciated.

elangelo commented 5 years ago

after closing and reopening visual studio my branch actually builds something that works for me. I don't want to create a PR for this because it's clearly not sufficient but maybe you could already have a look?

https://github.com/elangelo/vsSolutionBuildEvent/commit/2c04d3f641a9a645e95f7b8c1616872df996cc81

3F commented 5 years ago

@elangelo we're using VSIX manifest v1 with the following list of SupportedProducts Elements (VSX Schema) for support all products starting from VS2010+. But this is obsolete way after VS 15.0 (read #36)

As for temp VS2010+solution, you can try to add partial support for 16.0 via the same <VisualStudio Version="16.0"> record: https://github.com/3F/vsSolutionBuildEvent/blob/e6f5f68fab83a145f71638e8600158996b3330a0/vsSolutionBuildEvent/source.extension.vsixmanifest#L44-L51

Moreover, I can accept PR if it will work in real use with latest RC VS2019. However, full support means usage VSIX v3 :( that of course requires separate distribution for: 

VS2010, - v1
VS2012, - v1, (v2 - optional)
VS2013, - v1, (v2 - optional)
VS2015, - v1, (v2 - optional)
VS2017, - v3
VS2019. - v3

I have no priority to this for the coming months, but you also can try to add configuration for build both packages (v1 & v3 manifest)

Anyway, most of changes for this product has been planned for this year, ie. some parts should be extracted into the new projects at all and some parts should be replaced by already existing:

3F commented 5 years ago

Today, #45 finally initiates support of the modern 15+ products (n. VS2017 is 15, VS2019 is 16).

Modern platform requires more than just update manifest file. I already added AsyncPackages implementation. So, basically we need to resolve some problems and add separate build of the both vsix packages. See the remaining subtasks there.

Welcome everyone to speed up the process, or please wait for my time.

3F commented 5 years ago

We're fully ready for VS2019 and now completely integrated with *VS2017.

Other:

All binaries will be available from our GitHub Releases Page. (I've plan to migrate from sf for new publishing)

Everyone, please also test the last CI build before public release!

Known problems here: https://github.com/3F/vsSolutionBuildEvent/pull/45