3Hren / blackhole

Yet another logging library.
MIT License
201 stars 57 forks source link

Fixed #186: Cannot compile with recent boost (clang/gcc) #189

Closed Maturin closed 5 years ago

Maturin commented 5 years ago

With boost version 1.66.0 the template parameters of basic_socket were changed and additional includes are needed.

codecov[bot] commented 5 years ago

Codecov Report

Merging #189 into master will increase coverage by 0.27%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage    83.2%   83.47%   +0.27%     
==========================================
  Files         140      140              
  Lines        7019     7019              
==========================================
+ Hits         5840     5859      +19     
+ Misses       1179     1160      -19
Impacted Files Coverage Δ
src/sink/socket/udp.hpp 100% <ø> (ø) :arrow_up:
src/sink/socket/tcp.hpp 100% <ø> (ø) :arrow_up:
src/sink/socket/tcp.cpp 88.13% <ø> (ø) :arrow_up:
src/sink/asynchronous.p.cpp 68.96% <0%> (+1.72%) :arrow_up:
src/sink/console.cpp 85.33% <0%> (+4%) :arrow_up:
tests/src/unit/sink/console.cpp 92.3% <0%> (+5.12%) :arrow_up:
src/termcolor.cpp 91.66% <0%> (+36.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7af8b7c...8c9144b. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #189 into master will increase coverage by 0.27%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage    83.2%   83.47%   +0.27%     
==========================================
  Files         140      140              
  Lines        7019     7019              
==========================================
+ Hits         5840     5859      +19     
+ Misses       1179     1160      -19
Impacted Files Coverage Δ
src/sink/socket/udp.hpp 100% <ø> (ø) :arrow_up:
src/sink/socket/tcp.hpp 100% <ø> (ø) :arrow_up:
src/sink/socket/tcp.cpp 88.13% <ø> (ø) :arrow_up:
src/sink/asynchronous.p.cpp 68.96% <0%> (+1.72%) :arrow_up:
src/sink/console.cpp 85.33% <0%> (+4%) :arrow_up:
tests/src/unit/sink/console.cpp 92.3% <0%> (+5.12%) :arrow_up:
src/termcolor.cpp 91.66% <0%> (+36.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7af8b7c...8c9144b. Read the comment docs.

3Hren commented 5 years ago

Thanks!