3Hren / blackhole

Yet another logging library.
MIT License
201 stars 57 forks source link

Fixed #188: Update Google Test to 1.9 #191

Closed Maturin closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #191 into master will increase coverage by 0.27%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage    83.2%   83.47%   +0.27%     
==========================================
  Files         140      140              
  Lines        7019     7019              
==========================================
+ Hits         5840     5859      +19     
+ Misses       1179     1160      -19
Impacted Files Coverage Δ
src/sink/asynchronous.p.cpp 68.96% <0%> (+1.72%) :arrow_up:
src/sink/console.cpp 85.33% <0%> (+4%) :arrow_up:
tests/src/unit/sink/console.cpp 92.3% <0%> (+5.12%) :arrow_up:
src/termcolor.cpp 91.66% <0%> (+36.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3e0a8f1...900a390. Read the comment docs.

Maturin commented 5 years ago

Shippable has a problem with compiling Google Test 1.9. I don't know which cmake version, they are using. At console log I could only see cmake 2.8. That might be a problem. Google Test requires 2.8.8.

blackholes cmake minimum requirement is 2.6 right now. Unfortunately I was using cmake 3.12.4, so I didn't noticed this problem before.

@3Hren Do you have some requirements, which prevents us from changing the minimum cmake version for blackhole?

3Hren commented 5 years ago

AFAIK, cmake 2.6 is the maximum version on Ubuntu 14.04, which is being used by guys I wrote this library. Maybe, it's already not.

@shaitan can you tell us about platforms Blackhole is used on now, please?

shaitan commented 5 years ago

We still have Ubuntu 14.04, but the highest available version of cmake is 2.8.12.2-0ubuntu3. So minimum requirement could be updated to 2.8.8.

Maturin commented 5 years ago

I investigated this issue a little bit more. The Google Test CMakeLists.txt states that the minimum requirement is 2.6.2, but this is actually wrong. The minimum requirement is 3.0.0 and an issue exist for changing this.

My tests showed that Google Test 1.8.0 is the last version, which builds with pre 3.0.0 cmake versions, 1.8.1 fails already.

Since Ubuntu 14.04 with cmake 2.8.12 is a hard requirement and thus, Google Test 1.8.0, I added a cmake version check. With cmake before 3.0.0 Google Test 1.8.0 is used and with cmake after 3.0.0 the latest Google Test version is used.

3Hren commented 5 years ago

Sorry for the long reply. LGTM!