Closed Maturin closed 5 years ago
Shippable has a problem with compiling Google Test 1.9. I don't know which cmake version, they are using. At console log I could only see cmake 2.8. That might be a problem. Google Test requires 2.8.8.
blackholes cmake minimum requirement is 2.6 right now. Unfortunately I was using cmake 3.12.4, so I didn't noticed this problem before.
@3Hren Do you have some requirements, which prevents us from changing the minimum cmake version for blackhole?
AFAIK, cmake 2.6 is the maximum version on Ubuntu 14.04, which is being used by guys I wrote this library. Maybe, it's already not.
@shaitan can you tell us about platforms Blackhole is used on now, please?
We still have Ubuntu 14.04, but the highest available version of cmake is 2.8.12.2-0ubuntu3
. So minimum requirement could be updated to 2.8.8
.
I investigated this issue a little bit more. The Google Test CMakeLists.txt states that the minimum requirement is 2.6.2, but this is actually wrong. The minimum requirement is 3.0.0 and an issue exist for changing this.
My tests showed that Google Test 1.8.0 is the last version, which builds with pre 3.0.0 cmake versions, 1.8.1 fails already.
Since Ubuntu 14.04 with cmake 2.8.12 is a hard requirement and thus, Google Test 1.8.0, I added a cmake version check. With cmake before 3.0.0 Google Test 1.8.0 is used and with cmake after 3.0.0 the latest Google Test version is used.
Sorry for the long reply. LGTM!
Codecov Report
68.96% <0%> (+1.72%)
85.33% <0%> (+4%)
92.3% <0%> (+5.12%)
91.66% <0%> (+36.11%)
Continue to review full report at Codecov.