Fix Tpms' `generate` method with specific `cell_size` and/or `repeat_cell` - Githubissues

3MAH / microgen

Microstructure generation

https://3mah.github.io

GNU General Public License v3.0

68 stars 8 forks source link

Fix Tpms' `generate` method with specific `cell_size` and/or `repeat_cell` #43

Closed kmarchais closed 7 months ago

kmarchais commented 7 months ago

Fixes #42.

This PR also :

adds a test for the case of the issue and modifies the structure of the tests for the shapes, splitting test_shapes.py into shapes/test_shapes.py and shapes/test_tpms.py. The new test is tests/shapes/test_tpms.py::test_tpms_given_non_default_cell_size_and_repeat_cell_must_have_same_volume_with_cad_and_vtk.
Fixes pylint issues in test_tpms.py and microgen/shape/tpms.py