Unify 3mfverify.exe with xml-linting in lib3MF-repo

martinweismann commented 6 years ago

https://github.com/3MFConsortium/lib3mf/tree/XML_Schema_Validation/Tools/Schema contains scripts to perform xml-schema validation for an individual 3dmodel.model against the xsd-files from the different published extensions.

3mfverify.exe appears to verify much more (OPC structure,…) but does not include the latest extensions.

@pencerw : Let's work on unifying the functionality from these tools. Do you know any internals about the 3mfverify-tool? It might suffice to feed the correct schemata into it.

pencerw commented 6 years ago

@martinweismann unfortunately I came into this repo only in January, and know nothing about the source of these files: https://github.com/3MFConsortium/3mf-samples/tree/master/3mf-Verify

It appears that @pabloprado added them to the repository - perhaps he or @alexanderoster knows?

thatrani commented 5 years ago

@sawhite500 , is there a replacement for 3mfverify.exe that HP created?

ghost commented 5 years ago

@sawhite500 , is there a replacement for 3mfverify.exe that HP created?

I just checked - there hasn't been any activity on that tool for well over a year. Is there a need / request to add capability from the POV of the consortium?

KrisIverson commented 5 years ago

I do not clearly recall, but I thought MS supplied the 3mfverify tool? I remember adding code to URL link to 3MF documentation when errors were detected. I do not know if anyone is using this tool. We had aspirations to move it to an online service or expand https://3mf.azurewebsite.net with this functionality but did not make progress towards that.

-K

From: Scott White notifications@github.com Sent: Wednesday, June 26, 2019 11:27 AM To: 3MFConsortium/3mf-samples 3mf-samples@noreply.github.com Cc: Kris Iverson Kris.Iverson@microsoft.com; Assign assign@noreply.github.com Subject: Re: [3MFConsortium/3mf-samples] Unify 3mfverify.exe with xml-linting in lib3MF-repo (#11)

@sawhite500https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsawhite500&data=02%7C01%7CKris.Iverson%40microsoft.com%7C8832f9912e1d411875ca08d6fa63d82f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636971704064795414&sdata=KoNbY73bSRYUO9bgXDlZgJ%2BM%2BdtM15fUgIGyNXEErVU%3D&reserved=0 , is there a replacement for 3mfverify.exe that HP created?

I just checked - there hasn't been any activity on that tool for well over a year. Is there a need / request to add capability from the POV of the consortium?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F3MFConsortium%2F3mf-samples%2Fissues%2F11%3Femail_source%3Dnotifications%26email_token%3DAH2UYM4O6CEVUDDVFOY6ROTP4OYGJA5CNFSM4E4WNNU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYUNF5Y%23issuecomment-505991927&data=02%7C01%7CKris.Iverson%40microsoft.com%7C8832f9912e1d411875ca08d6fa63d82f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636971704064795414&sdata=HOsANzwe45%2BGbdI%2FVBNk%2F5yC%2FEamrgisX113etGWVgs%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAH2UYM6FGJ6RFUAOEXDNKYDP4OYGJANCNFSM4E4WNNUQ&data=02%7C01%7CKris.Iverson%40microsoft.com%7C8832f9912e1d411875ca08d6fa63d82f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636971704064805401&sdata=Mujiv0K8PuTUvfdU384VL70cpZKjlibZu9Q00M0YMKI%3D&reserved=0.

ghost commented 5 years ago

Good point Kris - I don’t remember exactly how it all went down. We did, I believe, share the code from HP’s verification tool with MSFT. It may be that it was never used (it’s written in Ruby).

Thanks,

Scott

From: Kris Iverson notifications@github.com Sent: Wednesday, June 26, 2019 12:33 PM To: 3MFConsortium/3mf-samples 3mf-samples@noreply.github.com Cc: White, Scott (PPS R&D) scott.a.white@hp.com; Mention mention@noreply.github.com Subject: Re: [3MFConsortium/3mf-samples] Unify 3mfverify.exe with xml-linting in lib3MF-repo (#11)

I do not clearly recall, but I thought MS supplied the 3mfverify tool? I remember adding code to URL link to 3MF documentation when errors were detected. I do not know if anyone is using this tool. We had aspirations to move it to an online service or expand https://3mf.azurewebsite.net https://3mf.azurewebsite.net with this functionality but did not make progress towards that.

-K

From: Scott White notifications@github.com<mailto:notifications@github.com> Sent: Wednesday, June 26, 2019 11:27 AM To: 3MFConsortium/3mf-samples 3mf-samples@noreply.github.com<mailto:3mf-samples@noreply.github.com> Cc: Kris Iverson Kris.Iverson@microsoft.com<mailto:Kris.Iverson@microsoft.com>; Assign assign@noreply.github.com<mailto:assign@noreply.github.com> Subject: Re: [3MFConsortium/3mf-samples] Unify 3mfverify.exe with xml-linting in lib3MF-repo (#11)

@sawhite500https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsawhite500&data=02%7C01%7CKris.Iverson%40microsoft.com%7C8832f9912e1d411875ca08d6fa63d82f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636971704064795414&sdata=KoNbY73bSRYUO9bgXDlZgJ%2BM%2BdtM15fUgIGyNXEErVU%3D&reserved=0<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsawhite500&data=02%7C01%7CKris.Iverson%40microsoft.com%7C8832f9912e1d411875ca08d6fa63d82f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636971704064795414&sdata=KoNbY73bSRYUO9bgXDlZgJ%2BM%2BdtM15fUgIGyNXEErVU%3D&reserved=0> , is there a replacement for 3mfverify.exe that HP created?

I just checked - there hasn't been any activity on that tool for well over a year. Is there a need / request to add capability from the POV of the consortium?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F3MFConsortium%2F3mf-samples%2Fissues%2F11%3Femail_source%3Dnotifications%26email_token%3DAH2UYM4O6CEVUDDVFOY6ROTP4OYGJA5CNFSM4E4WNNU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYUNF5Y%23issuecomment-505991927&data=02%7C01%7CKris.Iverson%40microsoft.com%7C8832f9912e1d411875ca08d6fa63d82f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636971704064795414&sdata=HOsANzwe45%2BGbdI%2FVBNk%2F5yC%2FEamrgisX113etGWVgs%3D&reserved=0<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F3MFConsortium%2F3mf-samples%2Fissues%2F11%3Femail_source%3Dnotifications%26email_token%3DAH2UYM4O6CEVUDDVFOY6ROTP4OYGJA5CNFSM4E4WNNU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYUNF5Y%23issuecomment-505991927&data=02%7C01%7CKris.Iverson%40microsoft.com%7C8832f9912e1d411875ca08d6fa63d82f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636971704064795414&sdata=HOsANzwe45%2BGbdI%2FVBNk%2F5yC%2FEamrgisX113etGWVgs%3D&reserved=0>, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAH2UYM6FGJ6RFUAOEXDNKYDP4OYGJANCNFSM4E4WNNUQ&data=02%7C01%7CKris.Iverson%40microsoft.com%7C8832f9912e1d411875ca08d6fa63d82f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636971704064805401&sdata=Mujiv0K8PuTUvfdU384VL70cpZKjlibZu9Q00M0YMKI%3D&reserved=0<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAH2UYM6FGJ6RFUAOEXDNKYDP4OYGJANCNFSM4E4WNNUQ&data=02%7C01%7CKris.Iverson%40microsoft.com%7C8832f9912e1d411875ca08d6fa63d82f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636971704064805401&sdata=Mujiv0K8PuTUvfdU384VL70cpZKjlibZu9Q00M0YMKI%3D&reserved=0>.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/3MFConsortium/3mf-samples/issues/11?email_source=notifications&email_token=ABXVMXG7B6XT4H2CTKBZHZ3P4OY35A5CNFSM4E4WNNU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYUNXCI#issuecomment-505994121, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABXVMXCTPGTFS6D5DN2I7WDP4OY35ANCNFSM4E4WNNUQ.

KrisIverson commented 5 years ago

What kind of tool do we want for the future?

From: Scott White notifications@github.com Sent: Wednesday, June 26, 2019 12:01 PM To: 3MFConsortium/3mf-samples 3mf-samples@noreply.github.com Cc: Kris Iverson Kris.Iverson@microsoft.com; Assign assign@noreply.github.com Subject: Re: [3MFConsortium/3mf-samples] Unify 3mfverify.exe with xml-linting in lib3MF-repo (#11)

Good point Kris - I don’t remember exactly how it all went down. We did, I believe, share the code from HP’s verification tool with MSFT. It may be that it was never used (it’s written in Ruby).

Thanks,

Scott

From: Kris Iverson notifications@github.com<mailto:notifications@github.com> Sent: Wednesday, June 26, 2019 12:33 PM To: 3MFConsortium/3mf-samples 3mf-samples@noreply.github.com<mailto:3mf-samples@noreply.github.com> Cc: White, Scott (PPS R&D) scott.a.white@hp.com<mailto:scott.a.white@hp.com>; Mention mention@noreply.github.com<mailto:mention@noreply.github.com> Subject: Re: [3MFConsortium/3mf-samples] Unify 3mfverify.exe with xml-linting in lib3MF-repo (#11)

I do not clearly recall, but I thought MS supplied the 3mfverify tool? I remember adding code to URL link to 3MF documentation when errors were detected. I do not know if anyone is using this tool. We had aspirations to move it to an online service or expand https://3mf.azurewebsite.net https://3mf.azurewebsite.net<https://3mf.azurewebsite.net%3chttps:/3mf.azurewebsite.net> with this functionality but did not make progress towards that.

-K

From: Scott White notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>> Sent: Wednesday, June 26, 2019 11:27 AM To: 3MFConsortium/3mf-samples 3mf-samples@noreply.github.com<mailto:3mf-samples@noreply.github.com<mailto:3mf-samples@noreply.github.com%3cmailto:3mf-samples@noreply.github.com>> Cc: Kris Iverson Kris.Iverson@microsoft.com<mailto:Kris.Iverson@microsoft.com<mailto:Kris.Iverson@microsoft.com%3cmailto:Kris.Iverson@microsoft.com>>; Assign assign@noreply.github.com<mailto:assign@noreply.github.com<mailto:assign@noreply.github.com%3cmailto:assign@noreply.github.com>> Subject: Re: [3MFConsortium/3mf-samples] Unify 3mfverify.exe with xml-linting in lib3MF-repo (#11)

@sawhite500<https://github.com/sawhite500; , is there a replacement for 3mfverify.exe that HP created?

I just checked - there hasn't been any activity on that tool for well over a year. Is there a need / request to add capability from the POV of the consortium?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub<https://github.com/3MFConsortium/3mf-samples/issues/11?email_source=notifications&email_token=AH2UYM4O6CEVUDDVFOY6ROTP4OYGJA5CNFSM4E4WNNU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYUNF5Y#issuecomment-505991927;, or mute the thread<https://github.com/notifications/unsubscribe-auth/AH2UYM6FGJ6RFUAOEXDNKYDP4OYGJANCNFSM4E4WNNUQ;.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/3MFConsortium/3mf-samples/issues/11?email_source=notifications&email_token=ABXVMXG7B6XT4H2CTKBZHZ3P4OY35A5CNFSM4E4WNNU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYUNXCI#issuecomment-505994121<https://github.com/sawhite500;%20,%20is%20there%20a%20replacement%20for%203mfverify.exe%20that%20HP%20created?%20%0b%0bI%20just%20checked%20-%20there%20hasn't%20been%20any%20activity%20on%20that%20tool%20for%20well%20over%20a%20year.%20Is%20there%20a%20need%20/%20request%20to%20add%20capability%20from%20the%20POV%20of%20the%20consortium?%20%0b%0b—%20%0bYou%20are%20receiving%20this%20because%20you%20were%20assigned.%20%0bReply%20to%20this%20email%20directly,%20view%20it%20on%20GitHub%3chttps://github.com/3MFConsortium/3mf-samples/issues/11?email_source=notifications&email_token=AH2UYM4O6CEVUDDVFOY6ROTP4OYGJA5CNFSM4E4WNNU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYUNF5Y#issuecomment-505991927;,%20or%20mute%20the%20thread<https://github.com/notifications/unsubscribe-auth/AH2UYM6FGJ6RFUAOEXDNKYDP4OYGJANCNFSM4E4WNNUQ;.%20—%20You%20are%20receiving%20this%20because%20you%20were%20mentioned.%20Reply%20to%20this%20email%20directly,%20view%20it%20on%20GitHub<https://github.com/3MFConsortium/3mf-samples/issues/11?email_source=notifications&email_token=ABXVMXG7B6XT4H2CTKBZHZ3P4OY35A5CNFSM4E4WNNU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYUNXCI#issuecomment-505994121>, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABXVMXCTPGTFS6D5DN2I7WDP4OY35ANCNFSM4E4WNNUQ.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F3MFConsortium%2F3mf-samples%2Fissues%2F11%3Femail_source%3Dnotifications%26email_token%3DAH2UYM2TNXNV3WTB3GAM5T3P4O4GTA5CNFSM4E4WNNU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYUQEUQ%23issuecomment-506004050&data=02%7C01%7CKris.Iverson%40microsoft.com%7C963a19d218724e7bea8c08d6fa689f19%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636971724594572074&sdata=uYq%2BGEbR4EdMFh5nxiGUlEZQhBXxejvYfBxcBUjc%2F68%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAH2UYM3DZDJQV2TGBA4UWOLP4O4GTANCNFSM4E4WNNUQ&data=02%7C01%7CKris.Iverson%40microsoft.com%7C963a19d218724e7bea8c08d6fa689f19%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636971724594582068&sdata=jIwqCdvWgy426Q8KqSEBBLSlMHf2K3G4IJj7Pg1zoj0%3D&reserved=0.

martinweismann commented 5 years ago

I see two main users of such a tool:

As an implementer of the 3MF standard I would like a tool that, given a 3MF file from someone else, tells me, whether it is valid (do i have to accept this file?) and whether files created by my tool are valid (do others have to accept this file?)
As a user working with 3MF files, I want to be able to point others (producers, consumers) to an authoritative tool that can judge whether a 3mf-file is valid. This way, interoperation between tools can be put on very solid grounds without deep understanding of the 3MF specifications. (Obviously, this does not replace detailed spec knowledge if errors or interop-problems arise)

What kind of tool should this be:

3mfverify was not to bad at that. As far as I remember it verifies the OPC package structure and verifies, whether the 3dmodel and the relationship-files are a valid instances of their respective schemata. However, it is limited to the core spec, and it did not respect any "soft parts" of the core specification, i.e. wording of the specification that can not be backed into an XSD, e.g. one MUST not reference resource IDs of objects defined later in a file.
Arguably, one can say, that these capabilities fall into the scope of a reference implementation itself. However, tools reading a file type are usually held to be forgiving about errors in files. E.g. XML linting and verification of schema conformance should not part of the parsing a 3MF file, since this is a) a deteriorates performance b) might lead to rejection of files that could easily be understood by others although they violate the schema (e.g. unknown attributes of an element within the namespace of the core-spec).

thatrani commented 5 years ago

I would also add to the wishlist that it is a web service.

3MFConsortium / 3mf-samples

Unify 3mfverify.exe with xml-linting in lib3MF-repo #11