search

3MFConsortium / 3mf-samples

The 3MF Samples repository contains implementation guidance, 3MF sample files and conformance tests for the 3MF Specification.
http://www.3mf.io
BSD 2-Clause "Simplified" License
46 stars 23 forks source link

Undefined XML namespace in multiprop-metallic.3mf #24

Closed Mugen87 closed 4 years ago

Mugen87 commented 4 years ago

I'm using the sample files to add new features to the 3MF importer of three.js. When working with multiprop-metallic.3mf, I've realized that selecting the child elements of pbmetallicdisplayproperties via querySelectorAll() does not work because pbmetallic is assigned to an undefined XML namespace (ms). Here is the problematic part:

<m:pbmetallicdisplayproperties id="9">
    <ms:pbmetallic name="MetalProp" metallicness="1" roughness="0.2" />
</m:pbmetallicdisplayproperties>

It would be great if the file can be fixed so I can used it to verify the loader's logic 😇

jordig100 commented 4 years ago

@Mugen87, files updated in the fixes branch. You might use it, before they got published.