search

3MFConsortium / 3mf-samples

The 3MF Samples repository contains implementation guidance, 3MF sample files and conformance tests for the 3MF Specification.
http://www.3mf.io
BSD 2-Clause "Simplified" License
46 stars 23 forks source link

Multiproperty examples are not valid #25

Closed martinweismann closed 4 years ago

martinweismann commented 4 years ago

Some of the multiproperties examples are invalid: a. https://github.com/3MFConsortium/3mf-samples/blob/master/examples/material/multiprop-opaque.3mf has no object-level pid b. https://github.com/3MFConsortium/3mf-samples/blob/master/examples/material/multiprop-translucent.3mf has no object-level pid and prefixes "translucent" with at “ms” namespace-prefix c. https://github.com/3MFConsortium/3mf-samples/blob/master/examples/material/multiprop-metallic.3mf has no object-level pid and prefixes "pbmetallic" with at “ms” namespace-prefix

jordig100 commented 4 years ago

Created pull request with this fix and pending changes.

martinweismann commented 4 years ago

@jordig100 : did you remove the multiprop-translucent and -metallic on purpose in the PR?

jordig100 commented 4 years ago

Restored the files removed by mistake