Closed feliperoos closed 2 years ago
Merging #292 (9bb0d8c) into develop (30d5c2e) will increase coverage by
2.67%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## develop #292 +/- ##
===========================================
+ Coverage 72.83% 75.50% +2.67%
===========================================
Files 418 419 +1
Lines 23280 28406 +5126
===========================================
+ Hits 16955 21447 +4492
- Misses 6325 6959 +634
Impacted Files | Coverage Δ | |
---|---|---|
...ce/Common/Platform/NMR_ExportStream_Compressed.cpp | 65.85% <100.00%> (ø) |
|
...ce/Common/Platform/NMR_ImportStream_Compressed.cpp | 69.64% <100.00%> (+0.55%) |
:arrow_up: |
Source/API/lib3mf_multipropertygroup.cpp | 76.81% <0.00%> (-2.85%) |
:arrow_down: |
Autogenerated/Bindings/Cpp/lib3mf_implicit.hpp | 93.47% <0.00%> (-1.52%) |
:arrow_down: |
Source/Model/Classes/NMR_ModelSliceStack.cpp | 84.46% <0.00%> (-0.06%) |
:arrow_down: |
Include/API/lib3mf_reader.hpp | 100.00% <0.00%> (ø) |
|
Include/API/lib3mf_writer.hpp | 100.00% <0.00%> (ø) |
|
Autogenerated/Source/lib3mf_interfaces.hpp | 100.00% <0.00%> (ø) |
|
Autogenerated/Source/lib3mf_types.hpp | 19.56% <0.00%> (ø) |
|
Source/API/lib3mf_writer.cpp | 79.85% <0.00%> (+0.01%) |
:arrow_up: |
... and 7 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 30d5c2e...9bb0d8c. Read the comment docs.
There's a few tests failing, I still haven't gone through them.
This intends to fix Issue #291 as it has surfaced during tests we've been doing. I'll add more details after I can test it properly, then I'll change PR status to final.