3MFConsortium / lib3mf

lib3mf is an implementation of the 3D Manufacturing Format file standard
http://3mf.io
BSD 2-Clause "Simplified" License
228 stars 92 forks source link

Add platform native GUID creation #312

Closed martinweismann closed 1 year ago

martinweismann commented 1 year ago

Addresses https://github.com/3MFConsortium/lib3mf/issues/271 :

  1. there is now a switch to compile lib3mf such that it uses the UUID generation provided by the host OS: USE_PLATFORM_UUID. It is OFF by default.
  2. std::random_device is not static anymore, only std::mt19937 and std::mutex are still static.
codecov[bot] commented 1 year ago

Codecov Report

Base: 71.65% // Head: 71.65% // No change to project coverage :thumbsup:

Coverage data is based on head (851784d) compared to base (1c5598b). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #312 +/- ## ======================================== Coverage 71.65% 71.65% ======================================== Files 420 420 Lines 24213 24213 ======================================== Hits 17349 17349 Misses 6864 6864 ``` | [Impacted Files](https://codecov.io/gh/3MFConsortium/lib3mf/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3MFConsortium) | Coverage Δ | | |---|---|---| | [Include/Common/NMR\_UUID.h](https://codecov.io/gh/3MFConsortium/lib3mf/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3MFConsortium#diff-SW5jbHVkZS9Db21tb24vTk1SX1VVSUQuaA==) | `100.00% <ø> (ø)` | | | [Source/Common/NMR\_UUID.cpp](https://codecov.io/gh/3MFConsortium/lib3mf/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3MFConsortium#diff-U291cmNlL0NvbW1vbi9OTVJfVVVJRC5jcHA=) | `80.43% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3MFConsortium). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=3MFConsortium)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.