Updating Lib3MF dependent libraries

3MFConsortium / lib3mf

lib3mf is an implementation of the 3D Manufacturing Format file standard

http://3mf.io

BSD 2-Clause "Simplified" License

228 stars 92 forks source link

Updating Lib3MF dependent libraries #336

Closed gangatp closed 8 months ago

gangatp commented 8 months ago

updated third party libraries are:

fast_float v6.0.0
zlib v1.3
cpp-base64 v2.rc.08
libzip v1.10.1
googletest v1.14.0
LibreSSL v3.8.2

Except LibreSSL all other libraries can be updated by updating the submodule pointer and running the update_libs script. For LibreSSL download the library from https://ftp.openbsd.org/pub/OpenBSD/LibreSSL/ and manually copy it to libraries.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (465c0da) 69.74% compared to head (991caed) 69.19%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #336 +/- ## =========================================== - Coverage 69.74% 69.19% -0.55% =========================================== Files 271 271 Lines 29758 28688 -1070 =========================================== - Hits 20755 19851 -904 + Misses 9003 8837 -166 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gangatp commented 8 months ago

The codecoverage results are bit ambiguous. There is a 0.5% drop in code coverage without any direct file changes. In the previous run without the update of LibreSSL the code coverage is https://github.com/3MFConsortium/lib3mf/pull/335 69.75%. I have updated the LibreSSL library to new version and that should not impact on code coverage at all. So testing both of this commit points locally (before updating LibreSSL and after updating LibreSSL), before updating LibreSSL :

After updating LibreSSL:

So the files showing indirect changes in codecov should not be affected by this commit. This commit is safe to be merged.