Closed gangatp closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
465c0da
) 69.74% compared to head (991caed
) 69.19%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The codecoverage results are bit ambiguous. There is a 0.5% drop in code coverage without any direct file changes. In the previous run without the update of LibreSSL the code coverage is https://github.com/3MFConsortium/lib3mf/pull/335 69.75%. I have updated the LibreSSL library to new version and that should not impact on code coverage at all. So testing both of this commit points locally (before updating LibreSSL and after updating LibreSSL), before updating LibreSSL :
After updating LibreSSL:
So the files showing indirect changes in codecov should not be affected by this commit. This commit is safe to be merged.
updated third party libraries are:
Except LibreSSL all other libraries can be updated by updating the submodule pointer and running the update_libs script. For LibreSSL download the library from https://ftp.openbsd.org/pub/OpenBSD/LibreSSL/ and manually copy it to libraries.