Closed vijaiaeroastro closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.20%. Comparing base (
8ceec9c
) to head (5be552e
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This all looks great!
Tested on windows the CppNew and CPPDynamic new. CPPDynamic works out of the box. The CppNew example's CMakeList does not yet take care of copying over the shared library.
We will need to clearly define what the role of the old sdk will be in the future, and how the examples are made available.
@martinweismann In CppNew, do you expect the library to be copied over to the same location as the target binary ?
I think so. That would make the example run out of the box.
I will make the necessary changes.
@martinweismann The necessary CMake changes to fix VCPKG installation are included in the latest commits. For example, VCPKG requires the lib3mfConfig.cmake
to be inside the share/lib3mf
directory instead of the lib
folder. This necessitates changes in the lib3mfConfig.cmake
file, as the paths for the lib and bin directories are now different. These changes are dynamically handled in lib3mfConfig.cmake
based on whether it is a VCPKG or non-VCPKG installation.
Base branch : develop (Right after the 2.3.0-alpha release)
This PR introduces significant enhancements to the CMake infrastructure of lib3mf, detailed as follows: