search

3MFConsortium / lib3mf

lib3mf is an implementation of the 3D Manufacturing Format file standard
http://3mf.io
BSD 2-Clause "Simplified" License
228 stars 92 forks source link

fixing whitespace in string to double conversion #357

Closed gangatp closed 4 months ago

gangatp commented 4 months ago

The current solution skips the leading whitespace and ignores it when it's at the end. if the spaces are in between then, the conversion terminates whenever a space is found. 

  string        -> double

" XXXX.XX" -> xxxx.xx " XX XX" -> xx " XXXX.XX " -> xxxx.xx

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.22%. Comparing base (b203943) to head (f198b17).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #357 +/- ## =========================================== + Coverage 69.19% 69.22% +0.02% =========================================== Files 271 271 Lines 28691 28692 +1 =========================================== + Hits 19854 19862 +8 + Misses 8837 8830 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

martinweismann commented 4 months ago

Thanks @gangatp . Did you reformat the file?

If these files require reformatting, please do this in a separate commit , as the intended change cannot easily be recognized in the diff.

gangatp commented 4 months ago

Thanks @gangatp . Did you reformat the file?

If these files require reformatting, please do this in a separate commit , as the intended change cannot easily be recognized in the diff.

yes by mistake will clear it