search

3MFConsortium / lib3mf

lib3mf is an implementation of the 3D Manufacturing Format file standard
http://3mf.io
BSD 2-Clause "Simplified" License
228 stars 92 forks source link

Issue 363: changing double factor from int to long long #369

Closed gangatp closed 3 months ago

gangatp commented 3 months ago

SetDecimalPrecision not working for values above 9 decimal places.

I notice in the PR that created this API that we cast a very large number to an int, when it should probably be a long long (m_nPutDoubleFactor). I stongly suspect this will fix the issue.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.10%. Comparing base (9faac7c) to head (9aa95a6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #369 +/- ## ======================================== Coverage 71.10% 71.10% ======================================== Files 271 271 Lines 30307 30307 ======================================== Hits 21551 21551 Misses 8756 8756 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vijaiaeroastro commented 3 months ago

Looks good @gangatp

gangatp commented 2 months ago

Fixes #363