search

3MFConsortium / lib3mf

lib3mf is an implementation of the 3D Manufacturing Format file standard
http://3mf.io
BSD 2-Clause "Simplified" License
228 stars 92 forks source link

updating zlib 1.3.1 #374

Closed gangatp closed 2 months ago

gangatp commented 2 months ago

lib3mf now uses zlib 1.3.0, which is affected by the vulnerability (BDSA-2023-2778 CVE-2023-45853). Is lib3mf affected by this? zlib(v1.3) https://autodesk.app.blackduck.com/api/components/b9185555-6e31-401e-b373-bfec7955a8ab/versions/eb888ce9-e2b6-47f7-980e-b65e7d68e92a BDSA-2023-2778 https://autodesk.app.blackduck.com/api/vulnerabilities/BDSA-2023-2778/overview

so updating to zlib v1.3.1

Adding Mac OS target to 10.15 in cmake.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.10%. Comparing base (4889e3f) to head (9b97b0f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #374 +/- ## ======================================== Coverage 71.10% 71.10% ======================================== Files 271 271 Lines 30307 30307 ======================================== Hits 21551 21551 Misses 8756 8756 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gangatp commented 2 months ago

Looks good Pradeep.

Hi Vijai, I would like to merge this to develop and take this to release branch as well. Is that okay for you?

vijaiaeroastro commented 2 months ago

Sure. No issues. We have to redo all the artifacts anyway.