search

3MFConsortium / spec_core

3MF's Core specification
BSD 2-Clause "Simplified" License
55 stars 16 forks source link

Schema Images #14

Closed KrisIverson closed 6 years ago

KrisIverson commented 6 years ago

Many of the XSD images are blurry, sized weirdly, and inconsistent. It may be this way in the old spec, too, but didn't seem as obvious. I recommend producing new images that are consistently sized and look good in Markdown.

pencerw commented 6 years ago

@KrisIverson this is a good idea - I believe that the issue comes from scaling differences between Word and GFM. I believe @jordig100 had a method of producing the images that involved adjusting scaling in Visual Studio and then taking screenshots; I think we should also consider a max width as well.

jordig100 commented 6 years ago

Tomorrow is my last day before vacations. If we can close current PR today, I'll try to provide new pictures by tomorrow.

pencerw commented 6 years ago

@jordig100 @KrisIverson let's merge the PR now so that we can move forward with the other changes. the repository is still private, and we can have a final review before it goes public.

jordig100 commented 6 years ago

Created a new pull request with new images. Please review them.

jordig100 commented 6 years ago

Images updated