search

3MFConsortium / spec_core

3MF's Core specification
BSD 2-Clause "Simplified" License
55 stars 16 forks source link

Update shema diagrams #16

Closed jordig100 closed 6 years ago

jordig100 commented 6 years ago

Updated diagrams from visual studio's Content Model View at 130% scaling factor.

pencerw commented 6 years ago

@jordig100 i believe you are missing @anyattribute here: https://github.com/3MFConsortium/spec_core/blob/update-shema-diagrams/3MF%20Core%20Specification.md#chapter-5-material-resources

jordig100 commented 6 years ago

@pencerw you are right. It looks the @anyattribute was missing in the original diagram and schema. Do we add it?

pencerw commented 6 years ago

@jordig100 @KrisIverson @anyattribute is in the version that was master. it was also in the DOCX version of 1.2.2.

i am not especially familiar with this portion of the spec, so i will defer to you on whether it is needed. i assume it is, though?

KrisIverson commented 6 years ago

@anyattribute was missed in diagrams (and tables) in many areas of the Core and Materials spec in v1.0. So there are likely some places that still need updates. We should update them as we find them.